The view model can no longer be initialized without an app

fitnesstrax/app/src/components/day.rs

@@ -199,7 +199,7 @@ impl DayDetail {
 pub struct DayEditPrivate {
     on_finished: RefCell<Box<dyn Fn()>>,
     workout_rows: RefCell<gtk::Box>,
-    view_model: RefCell<DayDetailViewModel>,
+    view_model: RefCell<Option<DayDetailViewModel>>,
 }
 
 impl Default for DayEditPrivate {
@@ -212,7 +212,7 @@ impl Default for DayEditPrivate {
                     .hexpand(true)
                     .build(),
             ),
-            view_model: RefCell::new(DayDetailViewModel::default()),
+            view_model: RefCell::new(None),
         }
     }
 }
@@ -241,7 +241,7 @@ impl DayEdit {
         s.set_orientation(gtk::Orientation::Vertical);
         s.set_hexpand(true);
         *s.imp().on_finished.borrow_mut() = Box::new(on_finished);
-        *s.imp().view_model.borrow_mut() = view_model.clone();
+        *s.imp().view_model.borrow_mut() = Some(view_model.clone());
 
         let workout_buttons = workout_buttons(view_model.clone(), {
             let s = s.clone();
@@ -322,7 +322,11 @@ impl DayEdit {
             _ => panic!("Record type {:?} is not a Time/Distance record", type_),
         };
         let record = Record { id, data };
-        self.imp().view_model.borrow().update_record(record);
+        let view_model = self.imp().view_model.borrow();
+        let view_model = view_model
+            .as_ref()
+            .expect("DayEdit has not been initialized with a view model");
+        view_model.update_record(record);
     }
 }
 

fitnesstrax/app/src/view_models/day_detail.rs

@@ -92,12 +92,9 @@ impl<T: Clone + emseries::Recordable> Deref for RecordState<T> {
     }
 }
 
-#[derive(Default)]
-struct DayDetailViewModelInner {}
-
-#[derive(Clone, Default)]
+#[derive(Clone)]
 pub struct DayDetailViewModel {
-    app: Option<App>,
+    app: App,
     pub date: chrono::NaiveDate,
     weight: Arc<RwLock<Option<RecordState<ft_core::Weight>>>>,
     steps: Arc<RwLock<Option<RecordState<ft_core::Steps>>>>,
@@ -109,7 +106,7 @@ pub struct DayDetailViewModel {
 impl DayDetailViewModel {
     pub fn new(date: chrono::NaiveDate, records: Vec<Record<TraxRecord>>, app: App) -> Self {
         let s = Self {
-            app: Some(app),
+            app,
             date,
 
             weight: Arc::new(RwLock::new(None)),
@@ -231,15 +228,15 @@ impl DayDetailViewModel {
         glib::spawn_future({
             let s = self.clone();
             async move {
-                if let Some(app) = s.app {
                 let weight_record = s.weight.read().unwrap().clone();
                 match weight_record {
                     Some(RecordState::New(Record { data, .. })) => {
-                            let _ = app.put_record(TraxRecord::Weight(data)).await;
+                        let _ = s.app.put_record(TraxRecord::Weight(data)).await;
                     }
                     Some(RecordState::Original(_)) => {}
                     Some(RecordState::Updated(weight)) => {
-                            let _ = app
+                        let _ = s
+                            .app
                             .update_record(Record {
                                 id: weight.id,
                                 data: TraxRecord::Weight(weight.data),
@@ -253,11 +250,12 @@ impl DayDetailViewModel {
                 let steps_record = s.steps.read().unwrap().clone();
                 match steps_record {
                     Some(RecordState::New(Record { data, .. })) => {
-                            let _ = app.put_record(TraxRecord::Steps(data)).await;
+                        let _ = s.app.put_record(TraxRecord::Steps(data)).await;
                     }
                     Some(RecordState::Original(_)) => {}
                     Some(RecordState::Updated(steps)) => {
-                            let _ = app
+                        let _ = s
+                            .app
                             .update_record(Record {
                                 id: steps.id,
                                 data: TraxRecord::Steps(steps.data),
@@ -280,17 +278,16 @@ impl DayDetailViewModel {
                     println!("saving record: {:?}", record);
                     match record {
                         RecordState::New(Record { data, .. }) => {
-                                let _ = app.put_record(data).await;
+                            let _ = s.app.put_record(data).await;
                         }
                         RecordState::Original(_) => {}
                         RecordState::Updated(r) => {
-                                let _ = app.update_record(r.clone()).await;
+                            let _ = s.app.update_record(r.clone()).await;
                         }
                         RecordState::Deleted(_) => unimplemented!(),
                     }
                 }
             }
-            }
         });
     }
 

fitnesstrax/app/src/views/day_detail_view.rs

@@ -25,7 +25,7 @@ use std::cell::RefCell;
 #[derive(Default)]
 pub struct DayDetailViewPrivate {
     container: Singleton,
-    view_model: RefCell<DayDetailViewModel>,
+    view_model: RefCell<Option<DayDetailViewModel>>,
 }
 
 #[glib::object_subclass]
@@ -47,7 +47,7 @@ glib::wrapper! {
 impl DayDetailView {
     pub fn new(view_model: DayDetailViewModel) -> Self {
         let s: Self = Object::builder().build();
-        *s.imp().view_model.borrow_mut() = view_model;
+        *s.imp().view_model.borrow_mut() = Some(view_model);
 
         s.append(&s.imp().container);
 
@@ -57,18 +57,26 @@ impl DayDetailView {
     }
 
     fn view(&self) {
-        self.imp()
-            .container
-            .swap(&DayDetail::new(self.imp().view_model.borrow().clone(), {
+        let view_model = self.imp().view_model.borrow();
+        let view_model = view_model
+            .as_ref()
+            .expect("DayDetailView has not been initialized with a view_model")
+            .clone();
+
+        self.imp().container.swap(&DayDetail::new(view_model, {
             let s = self.clone();
             move || s.edit()
         }));
     }
 
     fn edit(&self) {
-        self.imp()
-            .container
-            .swap(&DayEdit::new(self.imp().view_model.borrow().clone(), {
+        let view_model = self.imp().view_model.borrow();
+        let view_model = view_model
+            .as_ref()
+            .expect("DayDetailView has not been initialized with a view_model")
+            .clone();
+
+        self.imp().container.swap(&DayEdit::new(view_model, {
             let s = self.clone();
             move || s.view()
         }));