Add the handler to delete a file

file-service/src/handlers.rs

@@ -87,7 +87,7 @@ pub async fn handle_auth(
     app: App,
     form: HashMap<String, String>,
 ) -> Result<http::Response<String>, Error> {
-    match form.get("token") {
+    match form.get("password") {
         Some(token) => match app.authenticate(AuthToken::from(token.clone())).await {
             Ok(Some(session_token)) => Response::builder()
                 .header("location", "/")
@@ -134,6 +134,25 @@ pub async fn handle_upload(
     }
 }
 
+pub async fn handle_delete(
+    app: App,
+    token: SessionToken,
+    id: FileId,
+) -> Result<http::Response<String>, Error> {
+    match app.validate_session(token).await {
+        Ok(Some(_)) => match app.delete_file(id).await {
+            Ok(_) => Response::builder()
+                .header("location", "/")
+                .status(StatusCode::SEE_OTHER)
+                .body("".to_owned()),
+            Err(_) => unimplemented!(),
+        },
+        _ => Response::builder()
+            .status(StatusCode::UNAUTHORIZED)
+            .body("".to_owned()),
+    }
+}
+
 fn serve_file<F>(
     info: FileInfo,
     file: F,

file-service/src/html.rs

@@ -74,7 +74,7 @@ impl Html for Form {
             None => "".to_owned(),
         };
         format!(
-            "<form action=\"{path}\" method=\"{method}\" {encoding}\n{elements}\n</form>\n",
+            "<form action=\"{path}\" method=\"{method}\" {encoding}>\n{elements}\n</form>\n",
             path = self.path,
             method = self.method,
             encoding = encoding,
@@ -236,92 +236,3 @@ impl Html for Button {
         )
     }
 }
-
-#[derive(Clone, Debug)]
-pub struct Image {
-    path: String,
-    attributes: Attributes,
-}
-
-impl Image {
-    pub fn new(path: &str) -> Self {
-        Self {
-            path: path.to_owned(),
-            attributes: Attributes::default(),
-        }
-    }
-
-    pub fn with_attributes<'a>(
-        mut self,
-        values: impl IntoIterator<Item = (&'a str, &'a str)>,
-    ) -> Self {
-        self.attributes = Attributes(
-            values
-                .into_iter()
-                .map(|(a, b)| (a.to_owned(), b.to_owned()))
-                .collect::<Vec<(String, String)>>(),
-        );
-        self
-    }
-}
-
-impl Html for Image {
-    fn to_html_string(&self) -> String {
-        format!(
-            "<img src={path} {attrs} />",
-            path = self.path,
-            attrs = self.attributes.to_string()
-        )
-    }
-}
-
-#[derive(Debug)]
-pub struct UnorderedList {
-    children: Vec<String>,
-    attributes: Attributes,
-}
-
-impl UnorderedList {
-    pub fn new() -> Self {
-        Self {
-            children: vec![],
-            attributes: Attributes::default(),
-        }
-    }
-
-    pub fn with_attributes<'a>(
-        mut self,
-        values: impl IntoIterator<Item = (&'a str, &'a str)>,
-    ) -> Self {
-        self.attributes = Attributes(
-            values
-                .into_iter()
-                .map(|(a, b)| (a.to_owned(), b.to_owned()))
-                .collect::<Vec<(String, String)>>(),
-        );
-        self
-    }
-}
-
-impl Html for UnorderedList {
-    fn to_html_string(&self) -> String {
-        let children = self
-            .children
-            .iter()
-            .map(|item| format!("<li>{}</li>", item.to_html_string()))
-            .collect::<Vec<String>>();
-        format!(
-            "<ul {attrs}>
-    {children}
-            </ul>",
-            attrs = self.attributes.to_string(),
-            children = children.join("\n")
-        )
-    }
-}
-
-impl HtmlContainer for UnorderedList {
-    fn add_html<H: Html>(&mut self, html: H) {
-        self.children.push(html.to_html_string())
-    }
-}

file-service/src/lib.rs

@@ -1,6 +1,6 @@
 mod store;
 
 pub use store::{
-    AuthDB, AuthError, AuthToken, FileHandle, FileId, FileInfo, ReadFileError, SessionToken, Store,
-    Username, WriteFileError,
+    AuthDB, AuthError, AuthToken, DeleteFileError, FileHandle, FileId, FileInfo, ReadFileError,
+    SessionToken, Store, Username, WriteFileError,
 };

file-service/src/main.rs

@@ -1,7 +1,7 @@
 extern crate log;
 
 use cookie::Cookie;
-use handlers::{file, handle_auth, handle_css, handle_upload, thumbnail};
+use handlers::{file, handle_auth, handle_css, handle_delete, handle_upload, thumbnail};
 use std::{
     collections::{HashMap, HashSet},
     convert::Infallible,
@@ -19,8 +19,8 @@ mod pages;
 const MAX_UPLOAD: u64 = 15 * 1024 * 1024;
 
 pub use file_service::{
-    AuthDB, AuthError, AuthToken, FileHandle, FileId, FileInfo, ReadFileError, SessionToken, Store,
-    Username, WriteFileError,
+    AuthDB, AuthError, AuthToken, DeleteFileError, FileHandle, FileId, FileInfo, ReadFileError,
+    SessionToken, Store, Username, WriteFileError,
 };
 pub use handlers::handle_index;
 
@@ -64,6 +64,11 @@ impl App {
     ) -> Result<FileHandle, WriteFileError> {
         self.store.write().await.add_file(filename, content)
     }
+
+    pub async fn delete_file(&self, id: FileId) -> Result<(), DeleteFileError> {
+        self.store.write().await.delete_file(&id)?;
+        Ok(())
+    }
 }
 
 fn with_app(app: App) -> impl Filter<Extract = (App,), Error = Infallible> + Clone {
@@ -134,6 +139,12 @@ pub async fn main() {
         .and(warp::multipart::form().max_length(MAX_UPLOAD))
         .then(handle_upload);
 
+    let delete_via_form = warp::path!("delete" / String)
+        .and(warp::post())
+        .and(with_app(app.clone()))
+        .and(with_session())
+        .then(|id, app, token| handle_delete(app, token, FileId::from(id)));
+
     let thumbnail = warp::path!(String / "tn")
         .and(warp::get())
         .and(warp::header::optional::<String>("if-none-match"))
@@ -150,6 +161,7 @@ pub async fn main() {
         root.or(styles)
             .or(auth)
             .or(upload_via_form)
+            .or(delete_via_form)
             .or(thumbnail)
             .or(file)
             .with(log),

file-service/src/pages.rs

@@ -4,13 +4,17 @@ use file_service::{FileHandle, FileInfo, ReadFileError};
 
 pub fn auth(_message: Option<String>) -> build_html::HtmlPage {
     build_html::HtmlPage::new()
-        .with_title("Authentication")
+        .with_title("Sign In")
         .with_stylesheet("/css")
         .with_container(
             Container::new(ContainerType::Div)
                 .with_attributes([("class", "authentication-page")])
-                .with_container(
-                    Container::new(ContainerType::Div)
+                .with_container(auth_form()),
+        )
+}
+
+fn auth_form() -> Container {
+    Container::default()
         .with_attributes([("class", "card authentication-form")])
         .with_html(
             Form::new()
@@ -18,18 +22,17 @@ pub fn auth(_message: Option<String>) -> build_html::HtmlPage {
                 .with_method("post")
                 .with_container(
                     Container::new(ContainerType::Div)
-                                        .with_attributes([("class", "authentication-form__label")])
-                                        .with_html(Label::new("for-token-input", "Authentication")),
-                                )
-                                .with_container(
-                                    Container::new(ContainerType::Div)
-                                        .with_attributes([("class", "authentication-form__input")])
                         .with_html(
-                                            Input::new("token", "token")
+                            Input::new("password", "password")
                                 .with_id("for-token-input")
-                                                .with_attributes([("size", "50")]),
-                                        ),
-                                ),
+                                .with_attributes([
+                                    ("size", "50"),
+                                    ("class", "authentication-form__input"),
+                                ]),
+                        )
+                        .with_html(
+                            Button::new("Sign In")
+                                .with_attributes([("class", "authentication-form__button")]),
                         ),
                 ),
         )
@@ -87,24 +90,24 @@ pub fn thumbnail(info: &FileInfo) -> Container {
         .with_html(
             Container::new(ContainerType::Div).with_link(
                 format!("/{}", *info.id),
-                Image::new(&format!("{}/tn", *info.id))
-                    .with_attributes([("class", "thumbnail__image")])
+                Container::default()
+                    .with_attributes([("class", "thumbnail")])
+                    .with_image(&format!("{}/tn", *info.id), "test data")
                     .to_html_string(),
             ),
         )
         .with_html(
             Container::new(ContainerType::Div)
                 .with_html(
-                    UnorderedList::new()
+                    Container::new(ContainerType::UnorderedList)
                         .with_attributes(vec![("class", "thumbnail__metadata")])
                         .with_html(info.name.clone())
                         .with_html(format!("{}", info.created.format("%Y-%m-%d"))),
                 )
                 .with_html(
                     Form::new()
-                        .with_path(&format!("/{}", *info.id))
+                        .with_path(&format!("/delete/{}", *info.id))
                         .with_method("post")
-                        .with_html(Input::new("hidden", "_method").with_value("delete"))
                         .with_html(Button::new("Delete")),
                 ),
         )

file-service/src/store/mod.rs

@@ -53,9 +53,6 @@ pub enum ReadFileError {
     #[error("permission denied")]
     PermissionDenied,
 
-    #[error("invalid path")]
-    InvalidPath,
-
     #[error("JSON error")]
     JSONError(#[from] serde_json::error::Error),
 
@@ -63,6 +60,36 @@ pub enum ReadFileError {
     IOError(#[from] std::io::Error),
 }
 
+#[derive(Debug, Error)]
+pub enum DeleteFileError {
+    #[error("file not found")]
+    FileNotFound(PathBuf),
+
+    #[error("metadata path is not a file")]
+    NotAFile,
+
+    #[error("cannot read metadata")]
+    PermissionDenied,
+
+    #[error("invalid metadata path")]
+    MetadataParseError(serde_json::error::Error),
+
+    #[error("IO error")]
+    IOError(#[from] std::io::Error),
+}
+
+impl From<ReadFileError> for DeleteFileError {
+    fn from(err: ReadFileError) -> Self {
+        match err {
+            ReadFileError::FileNotFound(path) => DeleteFileError::FileNotFound(path),
+            ReadFileError::NotAFile => DeleteFileError::NotAFile,
+            ReadFileError::PermissionDenied => DeleteFileError::PermissionDenied,
+            ReadFileError::JSONError(err) => DeleteFileError::MetadataParseError(err),
+            ReadFileError::IOError(err) => DeleteFileError::IOError(err),
+        }
+    }
+}
+
 #[derive(Debug, Error)]
 pub enum AuthError {
     #[error("authentication token is duplicated")]
@@ -369,7 +396,7 @@ impl Store {
         FileHandle::load(id, &self.files_root)
     }
 
-    pub fn delete_file(&mut self, id: &FileId) -> Result<(), WriteFileError> {
+    pub fn delete_file(&mut self, id: &FileId) -> Result<(), DeleteFileError> {
         let handle = FileHandle::load(id, &self.files_root)?;
         handle.delete();
         Ok(())

file-service/templates/style.css

@@ -29,6 +29,7 @@ body {
     justify-content: center;
     align-items: center;
     height: 200px;
+    margin: 8px;
 }
 
 .authentication-form {
@@ -133,6 +134,16 @@ body {
 
     .authentication-form {
         width: 100%;
+        display: flex;
+        flex-direction: column;
+    }
+
+    .authentication-form__input {
+        font-size: x-large;
+    }
+
+    .authentication-form__button {
+        font-size: x-large;
     }
 
     .upload-form__selector {