.vscode/settings.json

@@ -1,3 +0,0 @@
-{
-    "rust-analyzer.showUnlinkedFileNotification": false
-}

emseries/src/series.rs

@@ -108,7 +108,7 @@ where
                 Ok(line_) => {
                     match serde_json::from_str::<RecordOnDisk<T>>(line_.as_ref())
                         .map_err(EmseriesReadError::JSONParseError)
-                        .and_then(Record::try_from)
+                        .and_then(|record| Record::try_from(record))
                     {
                         Ok(record) => records.insert(record.id.clone(), record.clone()),
                         Err(EmseriesReadError::RecordDeleted(id)) => records.remove(&id),

emseries/src/types.rs

@@ -11,6 +11,9 @@ You should have received a copy of the GNU General Public License along with Lum
 */
 
 use chrono::{DateTime, FixedOffset, NaiveDate};
+use chrono_tz::UTC;
+use serde::de::DeserializeOwned;
+use serde::ser::Serialize;
 use std::{cmp::Ordering, fmt, io, str};
 use thiserror::Error;
 use uuid::Uuid;
@@ -90,9 +93,33 @@ impl str::FromStr for Timestamp {
     }
 }
 
+/*
+impl PartialEq for Timestamp {
+    fn eq(&self, other: &Timestamp) -> bool {
+        match (self, other) {
+            (Timestamp::DateTime(dt1), Timestamp::DateTime(dt2)) => {
+                dt1.with_timezone(&UTC) == dt2.with_timezone(&UTC)
+            }
+            // It's not clear to me what would make sense when I'm comparing a date and a
+            // timestamp. I'm going with a naive date comparison on the idea that what I'm wanting
+            // here is human scale, again.
+            (Timestamp::DateTime(dt1), Timestamp::Date(dt2)) => dt1.date_naive() == *dt2,
+            (Timestamp::Date(dt1), Timestamp::DateTime(dt2)) => *dt1 == dt2.date_naive(),
+            (Timestamp::Date(dt1), Timestamp::Date(dt2)) => *dt1 == *dt2,
+        }
+    }
+}
+*/
+
 impl PartialOrd for Timestamp {
     fn partial_cmp(&self, other: &Timestamp) -> Option<Ordering> {
-        Some(self.cmp(other))
+        // Some(self.cmp(other))
+        match (self, other) {
+            (Timestamp::DateTime(dt1), Timestamp::DateTime(dt2)) => dt1.partial_cmp(dt2),
+            (Timestamp::DateTime(dt1), Timestamp::Date(dt2)) => dt1.date_naive().partial_cmp(dt2),
+            (Timestamp::Date(dt1), Timestamp::DateTime(dt2)) => dt1.partial_cmp(&dt2.date_naive()),
+            (Timestamp::Date(dt1), Timestamp::Date(dt2)) => dt1.partial_cmp(dt2),
+        }
     }
 }
 

fitnesstrax/app/src/app.rs

@@ -14,6 +14,7 @@ General Public License for more details.
 You should have received a copy of the GNU General Public License along with FitnessTrax. If not, see <https://www.gnu.org/licenses/>.
 */
 
+use crate::types::DayInterval;
 use chrono::NaiveDate;
 use emseries::{time_range, Record, RecordId, Series, Timestamp};
 use ft_core::TraxRecord;
@@ -51,10 +52,12 @@ impl App {
                 .unwrap(),
         );
 
-        Self {
+        let s = Self {
             runtime,
             database: Arc::new(RwLock::new(database)),
-        }
+        };
+
+        s
     }
 
     pub async fn records(
@@ -73,7 +76,7 @@ impl App {
                             Timestamp::Date(end),
                             true,
                         ))
-                        .cloned()
+                        .map(|record| record.clone())
                         .collect::<Vec<Record<TraxRecord>>>();
                     Ok(records)
                 } else {

fitnesstrax/app/src/app_window.rs

@@ -16,7 +16,6 @@ You should have received a copy of the GNU General Public License along with Fit
 
 use crate::{
     app::App,
-    view_models::DayDetailViewModel,
     views::{DayDetailView, HistoricalView, PlaceholderView, View, WelcomeView},
 };
 use adw::prelude::*;
@@ -81,7 +80,7 @@ impl AppWindow {
             .orientation(gtk::Orientation::Vertical)
             .build();
 
-        let initial_view = View::Placeholder(PlaceholderView::default().upcast());
+        let initial_view = View::Placeholder(PlaceholderView::new().upcast());
 
         layout.append(&initial_view.widget());
 
@@ -115,10 +114,9 @@ impl AppWindow {
 
         s.navigation.connect_popped({
             let s = s.clone();
-            move |_, _| {
-                if let View::Historical(_) = *s.current_view.borrow() {
-                    s.load_records();
-                }
+            move |_, _| match *s.current_view.borrow() {
+                View::Historical(_) => s.load_records(),
+                _ => {}
             }
         });
 
@@ -139,12 +137,7 @@ impl AppWindow {
             Rc::new(move |date, records| {
                 let layout = gtk::Box::new(gtk::Orientation::Vertical, 0);
                 layout.append(&adw::HeaderBar::new());
-                // layout.append(&DayDetailView::new(date, records, s.app.clone()));
-                layout.append(&DayDetailView::new(DayDetailViewModel::new(
-                    date,
-                    records,
-                    s.app.clone(),
-                )));
+                layout.append(&DayDetailView::new(date, records, s.app.clone()));
                 let page = &adw::NavigationPage::builder()
                     .title(date.format("%Y-%m-%d").to_string())
                     .child(&layout)
@@ -192,4 +185,22 @@ impl AppWindow {
             }
         });
     }
+
+    fn on_put_record(&self, record: TraxRecord) {
+        glib::spawn_future_local({
+            let s = self.clone();
+            async move {
+                s.app.put_record(record).await;
+            }
+        });
+    }
+
+    fn on_update_record(&self, record: Record<TraxRecord>) {
+        glib::spawn_future_local({
+            let s = self.clone();
+            async move {
+                s.app.update_record(record).await;
+            }
+        });
+    }
 }

fitnesstrax/app/src/components/action_group.rs

@@ -14,8 +14,6 @@ General Public License for more details.
 You should have received a copy of the GNU General Public License along with FitnessTrax. If not, see <https://www.gnu.org/licenses/>.
 */
 
-//! ActionGroup and related structures
-
 use glib::Object;
 use gtk::{prelude::*, subclass::prelude::*};
 

fitnesstrax/app/src/components/day.rs

@@ -16,14 +16,11 @@ You should have received a copy of the GNU General Public License along with Fit
 
 // use chrono::NaiveDate;
 // use ft_core::TraxRecord;
-use crate::{
-    components::{ActionGroup, Weight},
-    view_models::DayDetailViewModel,
-};
+use crate::components::{ActionGroup, TimeDistanceView, Weight};
 use emseries::Record;
 use glib::Object;
 use gtk::{prelude::*, subclass::prelude::*};
-use std::cell::RefCell;
+use std::{cell::RefCell, rc::Rc};
 
 use super::weight::WeightEdit;
 
@@ -60,8 +57,8 @@ glib::wrapper! {
     pub struct DaySummary(ObjectSubclass<DaySummaryPrivate>) @extends gtk::Box, gtk::Widget, @implements gtk::Orientable;
 }
 
-impl Default for DaySummary {
-    fn default() -> Self {
+impl DaySummary {
+    pub fn new() -> Self {
         let s: Self = Object::builder().build();
         s.set_orientation(gtk::Orientation::Vertical);
         s.set_css_classes(&["day-summary"]);
@@ -70,12 +67,6 @@ impl Default for DaySummary {
 
         s
     }
-}
-
-impl DaySummary {
-    pub fn new() -> Self {
-        Self::default()
-    }
 
     pub fn set_data(&self, date: chrono::NaiveDate, records: Vec<Record<ft_core::TraxRecord>>) {
         self.imp()
@@ -89,11 +80,11 @@ impl DaySummary {
         if let Some(Record {
             data: ft_core::TraxRecord::Weight(weight_record),
             ..
-        }) = records.iter().find(|f| f.data.is_weight())
+        }) = records.iter().filter(|f| f.data.is_weight()).next()
         {
             let label = gtk::Label::builder()
                 .halign(gtk::Align::Start)
-                .label(weight_record.weight.to_string())
+                .label(&format!("{}", weight_record.weight))
                 .css_classes(["day-summary__weight"])
                 .build();
             self.append(&label);
@@ -111,14 +102,27 @@ impl DaySummary {
     }
 }
 
-#[derive(Default)]
-pub struct DayDetailPrivate {}
+pub struct DayDetailPrivate {
+    date: gtk::Label,
+    weight: RefCell<Option<gtk::Label>>,
+}
 
 #[glib::object_subclass]
 impl ObjectSubclass for DayDetailPrivate {
     const NAME: &'static str = "DayDetail";
     type Type = DayDetail;
     type ParentType = gtk::Box;
+
+    fn new() -> Self {
+        let date = gtk::Label::builder()
+            .css_classes(["daysummary-date"])
+            .halign(gtk::Align::Start)
+            .build();
+        Self {
+            date,
+            weight: RefCell::new(None),
+        }
+    }
 }
 
 impl ObjectImpl for DayDetailPrivate {}
@@ -130,7 +134,11 @@ glib::wrapper! {
 }
 
 impl DayDetail {
-    pub fn new<OnEdit>(view_model: DayDetailViewModel, on_edit: OnEdit) -> Self
+    pub fn new<OnEdit>(
+        date: chrono::NaiveDate,
+        records: Vec<Record<ft_core::TraxRecord>>,
+        on_edit: OnEdit,
+    ) -> Self
     where
         OnEdit: Fn() + 'static,
     {
@@ -159,7 +167,6 @@ impl DayDetail {
         s.add_controller(click_controller);
         */
 
-        /*
         let weight_record = records.iter().find_map(|record| match record {
             Record {
                 id,
@@ -167,12 +174,13 @@ impl DayDetail {
             } => Some((id.clone(), record.clone())),
             _ => None,
         });
-        */
 
-        let weight_view = Weight::new(view_model.weight());
+        let weight_view = match weight_record {
+            Some((id, data)) => Weight::new(Some(data.clone())),
+            None => Weight::new(None),
+        };
         s.append(&weight_view.widget());
 
-        /*
         records.into_iter().for_each(|record| {
             let record_view = match record {
                 Record {
@@ -216,20 +224,21 @@ impl DayDetail {
                 s.append(&record_view);
             }
         });
-        */
 
         s
     }
 }
 
 pub struct DayEditPrivate {
-    on_finished: RefCell<Box<dyn Fn()>>,
+    date: gtk::Label,
+    weight: Rc<WeightEdit>,
 }
 
 impl Default for DayEditPrivate {
     fn default() -> Self {
         Self {
-            on_finished: RefCell::new(Box::new(|| {})),
+            date: gtk::Label::new(None),
+            weight: Rc::new(WeightEdit::new(None)),
         }
     }
 }
@@ -250,51 +259,75 @@ glib::wrapper! {
 }
 
 impl DayEdit {
-    pub fn new<OnFinished>(view_model: DayDetailViewModel, on_finished: OnFinished) -> Self
+    pub fn new<PutRecordFn, UpdateRecordFn, CancelFn>(
+        date: chrono::NaiveDate,
+        records: Vec<Record<ft_core::TraxRecord>>,
+        on_put_record: PutRecordFn,
+        on_update_record: UpdateRecordFn,
+        on_cancel: CancelFn,
+    ) -> Self
     where
-        OnFinished: Fn() + 'static,
+        PutRecordFn: Fn(ft_core::TraxRecord) + 'static,
+        UpdateRecordFn: Fn(Record<ft_core::TraxRecord>) + 'static,
+        CancelFn: Fn() + 'static,
     {
         let s: Self = Object::builder().build();
         s.set_orientation(gtk::Orientation::Vertical);
         s.set_hexpand(true);
 
-        *s.imp().on_finished.borrow_mut() = Box::new(on_finished);
-
         s.append(
             &ActionGroup::builder()
                 .primary_action("Save", {
                     let s = s.clone();
-                    let view_model = view_model.clone();
+                    let records = records.clone();
                     move || {
-                        view_model.save();
-                        s.finish();
-                    }
-                })
-                .secondary_action("Cancel", {
-                    let s = s.clone();
-                    let view_model = view_model.clone();
-                    move || {
-                        view_model.revert();
-                        s.finish();
+                        let weight_record = records.iter().find_map(|record| match record {
+                            Record {
+                                id,
+                                data: ft_core::TraxRecord::Weight(w),
+                            } => Some((id, w)),
+                            _ => None,
+                        });
+
+                        let weight = s.imp().weight.value();
+
+                        if let Some(weight) = weight {
+                            match weight_record {
+                                Some((id, _)) => on_update_record(Record {
+                                    id: id.clone(),
+                                    data: ft_core::TraxRecord::Weight(ft_core::Weight {
+                                        date,
+                                        weight,
+                                    }),
+                                }),
+                                None => {
+                                    on_put_record(ft_core::TraxRecord::Weight(ft_core::Weight {
+                                        date,
+                                        weight,
+                                    }))
+                                }
+                            }
+                        };
                     }
                 })
+                .secondary_action("Cancel", on_cancel)
                 .build(),
         );
 
-        s.append(
-            &WeightEdit::new(view_model.weight(), {
-                let view_model = view_model.clone();
-                move |w| {
-                    view_model.set_weight(w);
-                }
-            })
-            .widget(),
-        );
+        let weight_record = records.iter().find_map(|record| match record {
+            Record {
+                id,
+                data: ft_core::TraxRecord::Weight(record),
+            } => Some((id.clone(), record.clone())),
+            _ => None,
+        });
+
+        match weight_record {
+            Some((_id, data)) => s.imp().weight.set_value(Some(data.weight)),
+            None => s.imp().weight.set_value(None),
+        };
+        s.append(&s.imp().weight.widget());
 
         s
     }
-
-    fn finish(&self) {
-        (self.imp().on_finished.borrow())()
-    }
 }

fitnesstrax/app/src/components/edit_view.rs

@@ -1,5 +1,5 @@
 /*
-Copyright 2024, Savanni D'Gerinel <savanni@luminescent-dreams.com>
+Copyright 2023, Savanni D'Gerinel <savanni@luminescent-dreams.com>
 
 This file is part of FitnessTrax.
 
@@ -14,5 +14,9 @@ General Public License for more details.
 You should have received a copy of the GNU General Public License along with FitnessTrax. If not, see <https://www.gnu.org/licenses/>.
 */
 
-mod day_detail;
-pub use day_detail::DayDetailViewModel;
+#[derive(Clone)]
+pub enum EditView<View, Edit> {
+    Unconfigured,
+    View(View),
+    Edit(Edit),
+}

fitnesstrax/app/src/components/mod.rs

@@ -20,6 +20,9 @@ pub use action_group::ActionGroup;
 mod day;
 pub use day::{DayDetail, DayEdit, DaySummary};
 
+mod edit_view;
+pub use edit_view::EditView;
+
 mod singleton;
 pub use singleton::{Singleton, SingletonImpl};
 

fitnesstrax/app/src/components/text_entry.rs

@@ -17,19 +17,14 @@ You should have received a copy of the GNU General Public License along with Fit
 use gtk::prelude::*;
 use std::{cell::RefCell, rc::Rc};
 
-#[derive(Clone, Debug)]
 pub struct ParseError;
 
-type Renderer<T> = dyn Fn(&T) -> String;
-type Parser<T> = dyn Fn(&str) -> Result<T, ParseError>;
-
 #[derive(Clone)]
 pub struct TextEntry<T: Clone + std::fmt::Debug> {
     value: Rc<RefCell<Option<T>>>,
     widget: gtk::Entry,
-    #[allow(unused)]
-    renderer: Rc<Renderer<T>>,
-    parser: Rc<Parser<T>>,
+    renderer: Rc<Box<dyn Fn(&T) -> String>>,
+    parser: Rc<Box<dyn Fn(&str) -> Result<T, ParseError>>>,
 }
 
 impl<T: Clone + std::fmt::Debug> std::fmt::Debug for TextEntry<T> {
@@ -50,15 +45,16 @@ impl<T: Clone + std::fmt::Debug + 'static> TextEntry<T> {
         V: Fn(&str) -> Result<T, ParseError> + 'static,
     {
         let widget = gtk::Entry::builder().placeholder_text(placeholder).build();
-        if let Some(ref v) = value {
-            widget.set_text(&renderer(v))
+        match value {
+            Some(ref v) => widget.set_text(&renderer(&v)),
+            None => {}
         }
 
         let s = Self {
             value: Rc::new(RefCell::new(value)),
             widget,
-            renderer: Rc::new(renderer),
-            parser: Rc::new(parser),
+            renderer: Rc::new(Box::new(renderer)),
+            parser: Rc::new(Box::new(parser)),
         };
 
         s.widget.buffer().connect_text_notify({
@@ -87,20 +83,19 @@ impl<T: Clone + std::fmt::Debug + 'static> TextEntry<T> {
         }
     }
 
-    #[allow(unused)]
     pub fn value(&self) -> Option<T> {
         let v = self.value.borrow().clone();
         self.value.borrow().clone()
     }
 
     pub fn set_value(&self, value: Option<T>) {
-        if let Some(ref v) = value {
-            self.widget.set_text(&(self.renderer)(v))
+        match value {
+            Some(ref v) => self.widget.set_text(&(self.renderer)(&v)),
+            None => {}
         }
         *self.value.borrow_mut() = value;
     }
 
-    #[allow(unused)]
     pub fn grab_focus(&self) {
         self.widget.grab_focus();
     }

fitnesstrax/app/src/components/time_distance.rs

@@ -24,7 +24,6 @@ use std::cell::RefCell;
 
 #[derive(Default)]
 pub struct TimeDistanceViewPrivate {
-    #[allow(unused)]
     record: RefCell<Option<TimeDistance>>,
 }
 
@@ -54,7 +53,7 @@ impl TimeDistanceView {
         first_row.append(
             &gtk::Label::builder()
                 .halign(gtk::Align::Start)
-                .label(record.datetime.format("%H:%M").to_string())
+                .label(&record.datetime.format("%H:%M").to_string())
                 .build(),
         );
 
@@ -97,7 +96,7 @@ impl TimeDistanceView {
                 .label(
                     record
                         .comments
-                        .map(|comments| comments.to_string())
+                        .map(|comments| format!("{}", comments))
                         .unwrap_or("".to_owned()),
                 )
                 .build(),

fitnesstrax/app/src/components/weight.rs

@@ -14,9 +14,12 @@ General Public License for more details.
 You should have received a copy of the GNU General Public License along with FitnessTrax. If not, see <https://www.gnu.org/licenses/>.
 */
 
-use crate::components::{ParseError, TextEntry};
+use crate::components::{EditView, ParseError, Singleton, TextEntry};
+use chrono::{Local, NaiveDate};
 use dimensioned::si;
-use gtk::prelude::*;
+use glib::{object::ObjectRef, Object};
+use gtk::{prelude::*, subclass::prelude::*};
+use std::{borrow::Borrow, cell::RefCell};
 
 #[derive(Default)]
 pub struct WeightViewPrivate {}
@@ -26,14 +29,14 @@ pub struct Weight {
 }
 
 impl Weight {
-    pub fn new(weight: Option<si::Kilogram<f64>>) -> Self {
+    pub fn new(weight: Option<ft_core::Weight>) -> Self {
         let label = gtk::Label::builder()
             .css_classes(["card", "weight-view"])
             .can_focus(true)
             .build();
 
         match weight {
-            Some(w) => label.set_text(&format!("{:?}", w)),
+            Some(w) => label.set_text(&format!("{:?}", w.weight)),
             None => label.set_text("No weight recorded"),
         }
 
@@ -51,30 +54,17 @@ pub struct WeightEdit {
 }
 
 impl WeightEdit {
-    pub fn new<OnUpdate>(weight: Option<si::Kilogram<f64>>, on_update: OnUpdate) -> Self
-    where
-        OnUpdate: Fn(si::Kilogram<f64>) + 'static,
-    {
+    pub fn new(weight: Option<ft_core::Weight>) -> Self {
         Self {
             entry: TextEntry::new(
                 "0 kg",
-                weight,
+                weight.map(|w| w.weight),
                 |val: &si::Kilogram<f64>| val.to_string(),
-                move |v: &str| {
-                    let new_weight = v.parse::<f64>().map(|w| w * si::KG).map_err(|_| ParseError);
-                    match new_weight {
-                        Ok(w) => {
-                            on_update(w);
-                            Ok(w)
-                        }
-                        Err(err) => Err(err),
-                    }
-                },
+                |v: &str| v.parse::<f64>().map(|w| w * si::KG).map_err(|_| ParseError),
             ),
         }
     }
 
-    #[allow(unused)]
     pub fn set_value(&self, value: Option<si::Kilogram<f64>>) {
         self.entry.set_value(value);
     }

fitnesstrax/app/src/main.rs

@@ -18,12 +18,12 @@ mod app;
 mod app_window;
 mod components;
 mod types;
-mod view_models;
 mod views;
 
 use adw::prelude::*;
 use app_window::AppWindow;
 use std::{env, path::PathBuf};
+use types::DayInterval;
 
 const APP_ID_DEV: &str = "com.luminescent-dreams.fitnesstrax.dev";
 const APP_ID_PROD: &str = "com.luminescent-dreams.fitnesstrax";

fitnesstrax/app/src/types.rs

@@ -21,8 +21,8 @@ impl Default for DayInterval {
 impl DayInterval {
     pub fn days(&self) -> impl Iterator<Item = NaiveDate> {
         DayIterator {
-            current: self.start,
-            end: self.end,
+            current: self.start.clone(),
+            end: self.end.clone(),
         }
     }
 }
@@ -37,7 +37,7 @@ impl Iterator for DayIterator {
 
     fn next(&mut self) -> Option<Self::Item> {
         if self.current <= self.end {
-            let val = self.current;
+            let val = self.current.clone();
             self.current += Duration::days(1);
             Some(val)
         } else {

fitnesstrax/app/src/view_models/day_detail.rs

@@ -1,217 +0,0 @@
-/*
-Copyright 2024, Savanni D'Gerinel <savanni@luminescent-dreams.com>
-
-This file is part of FitnessTrax.
-
-FitnessTrax is free software: you can redistribute it and/or modify it under the terms of the GNU
-General Public License as published by the Free Software Foundation, either version 3 of the
-License, or (at your option) any later version.
-
-FitnessTrax is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without
-even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-General Public License for more details.
-
-You should have received a copy of the GNU General Public License along with FitnessTrax. If not, see <https://www.gnu.org/licenses/>.
-*/
-
-use crate::app::App;
-use dimensioned::si;
-use emseries::{Record, RecordId, Recordable};
-use ft_core::TraxRecord;
-use std::{
-    collections::HashMap,
-    ops::Deref,
-    sync::{Arc, RwLock},
-};
-
-#[derive(Clone, Debug)]
-enum RecordState<T: Clone + Recordable> {
-    Original(Record<T>),
-    New(T),
-    Updated(Record<T>),
-    #[allow(unused)]
-    Deleted(Record<T>),
-}
-
-impl<T: Clone + emseries::Recordable> RecordState<T> {
-    #[allow(unused)]
-    fn id(&self) -> Option<&RecordId> {
-        match self {
-            RecordState::Original(ref r) => Some(&r.id),
-            RecordState::New(ref r) => None,
-            RecordState::Updated(ref r) => Some(&r.id),
-            RecordState::Deleted(ref r) => Some(&r.id),
-        }
-    }
-
-    fn with_value(self, value: T) -> RecordState<T> {
-        match self {
-            RecordState::Original(r) => RecordState::Updated(Record { data: value, ..r }),
-            RecordState::New(_) => RecordState::New(value),
-            RecordState::Updated(r) => RecordState::Updated(Record { data: value, ..r }),
-            RecordState::Deleted(r) => RecordState::Updated(Record { data: value, ..r }),
-        }
-    }
-
-    #[allow(unused)]
-    fn with_delete(self) -> Option<RecordState<T>> {
-        match self {
-            RecordState::Original(r) => Some(RecordState::Deleted(r)),
-            RecordState::New(r) => None,
-            RecordState::Updated(r) => Some(RecordState::Deleted(r)),
-            RecordState::Deleted(r) => Some(RecordState::Deleted(r)),
-        }
-    }
-}
-
-impl<T: Clone + emseries::Recordable> Deref for RecordState<T> {
-    type Target = T;
-    fn deref(&self) -> &Self::Target {
-        match self {
-            RecordState::Original(ref r) => &r.data,
-            RecordState::New(ref r) => r,
-            RecordState::Updated(ref r) => &r.data,
-            RecordState::Deleted(ref r) => &r.data,
-        }
-    }
-}
-
-#[derive(Default)]
-struct DayDetailViewModelInner {}
-
-#[derive(Clone, Default)]
-pub struct DayDetailViewModel {
-    app: Option<App>,
-    pub date: chrono::NaiveDate,
-    weight: Arc<RwLock<Option<RecordState<ft_core::Weight>>>>,
-    steps: Arc<RwLock<Option<RecordState<ft_core::Steps>>>>,
-    records: Arc<RwLock<HashMap<RecordId, RecordState<TraxRecord>>>>,
-}
-
-impl DayDetailViewModel {
-    pub fn new(date: chrono::NaiveDate, records: Vec<Record<TraxRecord>>, app: App) -> Self {
-        let (weight_records, records): (Vec<Record<TraxRecord>>, Vec<Record<TraxRecord>>) =
-            records.into_iter().partition(|r| r.data.is_weight());
-        let (step_records, records): (Vec<Record<TraxRecord>>, Vec<Record<TraxRecord>>) =
-            records.into_iter().partition(|r| r.data.is_steps());
-        Self {
-            app: Some(app),
-            date,
-            weight: Arc::new(RwLock::new(
-                weight_records
-                    .first()
-                    .and_then(|r| match r.data {
-                        TraxRecord::Weight(ref w) => Some((r.id.clone(), w.clone())),
-                        _ => None,
-                    })
-                    .map(|(id, w)| RecordState::Original(Record { id, data: w })),
-            )),
-            steps: Arc::new(RwLock::new(
-                step_records
-                    .first()
-                    .and_then(|r| match r.data {
-                        TraxRecord::Steps(ref w) => Some((r.id.clone(), w.clone())),
-                        _ => None,
-                    })
-                    .map(|(id, w)| RecordState::Original(Record { id, data: w })),
-            )),
-
-            records: Arc::new(RwLock::new(
-                records
-                    .into_iter()
-                    .map(|r| (r.id.clone(), RecordState::Original(r)))
-                    .collect::<HashMap<RecordId, RecordState<TraxRecord>>>(),
-            )),
-        }
-    }
-
-    pub fn weight(&self) -> Option<si::Kilogram<f64>> {
-        (*self.weight.read().unwrap()).as_ref().map(|w| w.weight)
-    }
-
-    pub fn set_weight(&self, new_weight: si::Kilogram<f64>) {
-        let mut record = self.weight.write().unwrap();
-        let new_record = match *record {
-            Some(ref rstate) => rstate.clone().with_value(ft_core::Weight {
-                date: self.date,
-                weight: new_weight,
-            }),
-            None => RecordState::New(ft_core::Weight {
-                date: self.date,
-                weight: new_weight,
-            }),
-        };
-        *record = Some(new_record);
-    }
-
-    pub fn steps(&self) -> Option<u32> {
-        (*self.steps.read().unwrap()).as_ref().map(|w| w.count)
-    }
-
-    pub fn set_steps(&self, new_count: u32) {
-        let mut record = self.steps.write().unwrap();
-        let new_record = match *record {
-            Some(ref rstate) => rstate.clone().with_value(ft_core::Steps {
-                date: self.date,
-                count: new_count,
-            }),
-            None => RecordState::New(ft_core::Steps {
-                date: self.date,
-                count: new_count,
-            }),
-        };
-        *record = Some(new_record);
-    }
-
-    pub fn save(&self) {
-        glib::spawn_future({
-            let s = self.clone();
-            async move {
-                if let Some(app) = s.app {
-                    let weight_record = s.weight.read().unwrap().clone();
-                    match weight_record {
-                        Some(RecordState::New(weight)) => {
-                            let _ = app.put_record(TraxRecord::Weight(weight)).await;
-                        }
-                        Some(RecordState::Original(_)) => {}
-                        Some(RecordState::Updated(weight)) => {
-                            let _ = app
-                                .update_record(Record {
-                                    id: weight.id,
-                                    data: TraxRecord::Weight(weight.data),
-                                })
-                                .await;
-                        }
-                        Some(RecordState::Deleted(_)) => {}
-                        None => {}
-                    }
-
-                    let records = s
-                        .records
-                        .write()
-                        .unwrap()
-                        .drain()
-                        .map(|(_, record)| record)
-                        .collect::<Vec<RecordState<TraxRecord>>>();
-
-                    for record in records {
-                        match record {
-                            RecordState::New(data) => {
-                                let _ = app.put_record(data).await;
-                            }
-                            RecordState::Original(_) => {}
-                            RecordState::Updated(r) => {
-                                let _ = app.update_record(r.clone()).await;
-                            }
-                            RecordState::Deleted(_) => unimplemented!(),
-                        }
-                    }
-                }
-            }
-        });
-    }
-
-    pub fn revert(&self) {
-        unimplemented!();
-    }
-}

fitnesstrax/app/src/views/day_detail_view.rs

@@ -15,17 +15,21 @@ You should have received a copy of the GNU General Public License along with Fit
 */
 
 use crate::{
+    app::App,
     components::{DayDetail, DayEdit, Singleton, SingletonImpl},
-    view_models::DayDetailViewModel,
 };
+use emseries::Record;
+use ft_core::TraxRecord;
 use glib::Object;
 use gtk::{prelude::*, subclass::prelude::*};
 use std::cell::RefCell;
 
 #[derive(Default)]
 pub struct DayDetailViewPrivate {
+    app: RefCell<Option<App>>,
     container: Singleton,
-    view_model: RefCell<DayDetailViewModel>,
+    date: RefCell<chrono::NaiveDate>,
+    records: RefCell<Vec<Record<TraxRecord>>>,
 }
 
 #[glib::object_subclass]
@@ -45,32 +49,116 @@ glib::wrapper! {
 }
 
 impl DayDetailView {
-    pub fn new(view_model: DayDetailViewModel) -> Self {
+    pub fn new(date: chrono::NaiveDate, records: Vec<Record<TraxRecord>>, app: App) -> Self {
         let s: Self = Object::builder().build();
-        *s.imp().view_model.borrow_mut() = view_model;
+
+        *s.imp().date.borrow_mut() = date;
+        *s.imp().records.borrow_mut() = records;
+        *s.imp().app.borrow_mut() = Some(app);
 
         s.append(&s.imp().container);
 
+        /*
+        s.imp()
+            .container
+            .swap(&DayDetail::new(date, records.clone(), {
+                let s = s.clone();
+                let records = records.clone();
+                move || {
+                    s.imp().container.swap(&DayEdit::new(
+                        date,
+                        records,
+                        s.on_put_record(),
+                        // s.on_update_record(),
+                        |_| {},
+                    ))
+                }
+            }));
+            */
+
         s.view();
 
         s
     }
 
     fn view(&self) {
-        self.imp()
-            .container
-            .swap(&DayDetail::new(self.imp().view_model.borrow().clone(), {
+        self.imp().container.swap(&DayDetail::new(
+            self.imp().date.borrow().clone(),
+            self.imp().records.borrow().clone(),
+            {
                 let s = self.clone();
                 move || s.edit()
-            }));
+            },
+        ));
     }
 
     fn edit(&self) {
-        self.imp()
-            .container
-            .swap(&DayEdit::new(self.imp().view_model.borrow().clone(), {
+        self.imp().container.swap(&DayEdit::new(
+            self.imp().date.borrow().clone(),
+            self.imp().records.borrow().clone(),
+            self.on_put_record(),
+            self.on_update_record(),
+            {
                 let s = self.clone();
                 move || s.view()
-            }));
+            },
+        ));
+    }
+
+    fn on_put_record(&self) -> Box<dyn Fn(ft_core::TraxRecord)> {
+        let s = self.clone();
+        let app = self.imp().app.clone();
+        Box::new(move |record| {
+            let s = s.clone();
+            let app = app.clone();
+            glib::spawn_future_local({
+                async move {
+                    match &*app.borrow() {
+                        Some(app) => {
+                            let id = app
+                                .put_record(record.clone())
+                                .await
+                                .expect("successful write");
+                            s.imp()
+                                .records
+                                .borrow_mut()
+                                .push(Record { id, data: record });
+                        }
+                        None => {}
+                    }
+                    s.view();
+                }
+            });
+        })
+    }
+
+    fn on_update_record(&self) -> Box<dyn Fn(Record<ft_core::TraxRecord>)> {
+        let s = self.clone();
+        let app = self.imp().app.clone();
+        Box::new(move |updated_record| {
+            let app = app.clone();
+
+            let mut records = s.imp().records.borrow_mut();
+            let idx = records.iter().position(|r| r.id == updated_record.id);
+            match idx {
+                Some(i) => records[i] = updated_record.clone(),
+                None => records.push(updated_record.clone()),
+            }
+
+            glib::spawn_future_local({
+                let s = s.clone();
+                async move {
+                    match &*app.borrow() {
+                        Some(app) => {
+                            let _ = app.update_record(updated_record).await;
+                        }
+                        None => {
+                            println!("no app!");
+                        }
+                    }
+                    s.view();
+                }
+            });
+        })
     }
 }

fitnesstrax/app/src/views/historical_view.rs

@@ -15,7 +15,7 @@ You should have received a copy of the GNU General Public License along with Fit
 */
 
 use crate::{components::DaySummary, types::DayInterval};
-use chrono::NaiveDate;
+use chrono::{Duration, Local, NaiveDate};
 use emseries::Record;
 use ft_core::TraxRecord;
 use glib::Object;
@@ -161,7 +161,7 @@ impl DayRecords {
     }
 
     pub fn date(&self) -> chrono::NaiveDate {
-        *self.imp().date.borrow()
+        self.imp().date.borrow().clone()
     }
 
     pub fn records(&self) -> Vec<Record<TraxRecord>> {
@@ -204,11 +204,11 @@ impl GroupedRecords {
         self
     }
 
-    fn items(&self) -> impl Iterator<Item = DayRecords> + '_ {
+    fn items<'a>(&'a self) -> impl Iterator<Item = DayRecords> + 'a {
         self.interval.days().map(|date| {
             self.data
                 .get(&date)
-                .cloned()
+                .map(|rec| rec.clone())
                 .unwrap_or(DayRecords::new(date, vec![]))
         })
     }
@@ -217,7 +217,6 @@ impl GroupedRecords {
 #[cfg(test)]
 mod test {
     use super::GroupedRecords;
-    use crate::types::DayInterval;
     use chrono::{FixedOffset, NaiveDate, TimeZone};
     use dimensioned::si::{KG, M, S};
     use emseries::{Record, RecordId};
@@ -273,12 +272,7 @@ mod test {
             },
         ];
 
-        let groups = GroupedRecords::new(DayInterval {
-            start: NaiveDate::from_ymd_opt(2023, 10, 14).unwrap(),
-            end: NaiveDate::from_ymd_opt(2023, 10, 14).unwrap(),
-        })
-        .with_data(records)
-        .data;
+        let groups = GroupedRecords::from(records).0;
         assert_eq!(groups.len(), 3);
     }
 }

fitnesstrax/app/src/views/placeholder_view.rs

@@ -38,8 +38,8 @@ glib::wrapper! {
     pub struct PlaceholderView(ObjectSubclass<PlaceholderViewPrivate>) @extends gtk::Box, gtk::Widget;
 }
 
-impl Default for PlaceholderView {
-    fn default() -> Self {
+impl PlaceholderView {
+    pub fn new() -> Self {
         let s: Self = Object::builder().build();
         s
     }

fitnesstrax/app/src/views/welcome_view.rs

@@ -14,7 +14,7 @@ General Public License for more details.
 You should have received a copy of the GNU General Public License along with FitnessTrax. If not, see <https://www.gnu.org/licenses/>.
 */
 
-use crate::components::FileChooserRow;
+use crate::{app::App, components::FileChooserRow};
 use glib::Object;
 use gtk::{prelude::*, subclass::prelude::*};
 use std::path::PathBuf;

fitnesstrax/core/src/legacy.rs

@@ -1,25 +1,23 @@
+use crate::types;
+
 #[cfg(test)]
 mod test {
     #[test]
-    #[ignore]
     fn read_a_legacy_set_rep_record() {
         unimplemented!()
     }
 
     #[test]
-    #[ignore]
     fn read_a_legacy_steps_record() {
         unimplemented!()
     }
 
     #[test]
-    #[ignore]
     fn read_a_legacy_time_distance_record() {
         unimplemented!()
     }
 
     #[test]
-    #[ignore]
     fn read_a_legacy_weight_record() {
         unimplemented!()
     }

fitnesstrax/core/src/types.rs

@@ -5,7 +5,6 @@ use serde::{Deserialize, Serialize};
 
 /// SetRep represents workouts like pushups or situps, which involve doing a "set" of a number of
 /// actions, resting, and then doing another set.
-#[allow(dead_code)]
 pub struct SetRep {
     /// I assume that a set/rep workout is only done once in a day.
     date: NaiveDate,
@@ -23,16 +22,6 @@ pub struct Steps {
     pub count: u32,
 }
 
-impl Recordable for Steps {
-    fn timestamp(&self) -> Timestamp {
-        Timestamp::Date(self.date)
-    }
-
-    fn tags(&self) -> Vec<String> {
-        vec![]
-    }
-}
-
 /// TimeDistance represents workouts characterized by a duration and a distance travelled. These
 /// sorts of workouts can occur many times a day, depending on how one records things. I might
 /// record a single 30-km workout if I go on a long-distanec ride. Or I might record multiple 5km
@@ -65,16 +54,6 @@ pub struct Weight {
     pub weight: si::Kilogram<f64>,
 }
 
-impl Recordable for Weight {
-    fn timestamp(&self) -> Timestamp {
-        Timestamp::Date(self.date)
-    }
-
-    fn tags(&self) -> Vec<String> {
-        vec![]
-    }
-}
-
 #[derive(Clone, Debug, PartialEq)]
 pub enum RecordType {
     BikeRide,
@@ -112,24 +91,23 @@ impl TraxRecord {
     }
 
     pub fn is_weight(&self) -> bool {
-        matches!(self, TraxRecord::Weight(_))
-    }
-
-    pub fn is_steps(&self) -> bool {
-        matches!(self, TraxRecord::Steps(_))
+        match self {
+            TraxRecord::Weight(_) => true,
+            _ => false,
+        }
     }
 }
 
 impl Recordable for TraxRecord {
     fn timestamp(&self) -> Timestamp {
         match self {
-            TraxRecord::BikeRide(rec) => Timestamp::DateTime(rec.datetime),
-            TraxRecord::Row(rec) => Timestamp::DateTime(rec.datetime),
-            TraxRecord::Run(rec) => Timestamp::DateTime(rec.datetime),
-            TraxRecord::Steps(rec) => rec.timestamp(),
-            TraxRecord::Swim(rec) => Timestamp::DateTime(rec.datetime),
-            TraxRecord::Walk(rec) => Timestamp::DateTime(rec.datetime),
-            TraxRecord::Weight(rec) => rec.timestamp(),
+            TraxRecord::BikeRide(rec) => Timestamp::DateTime(rec.datetime.clone()),
+            TraxRecord::Row(rec) => Timestamp::DateTime(rec.datetime.clone()),
+            TraxRecord::Run(rec) => Timestamp::DateTime(rec.datetime.clone()),
+            TraxRecord::Steps(rec) => Timestamp::Date(rec.date),
+            TraxRecord::Swim(rec) => Timestamp::DateTime(rec.datetime.clone()),
+            TraxRecord::Walk(rec) => Timestamp::DateTime(rec.datetime.clone()),
+            TraxRecord::Weight(rec) => Timestamp::Date(rec.date),
         }
     }
 
@@ -157,6 +135,6 @@ mod test {
         let id = series.put(record.clone()).unwrap();
 
         let record_ = series.get(&id).unwrap();
-        assert_eq!(record_.data, record);
+        assert_eq!(record_, record);
     }
 }