savanni
/
monorepo
1
0
Fork 0
Code Issues 69 Pull Requests Projects 6 Releases Wiki Activity

Import and update the file service application and orizentic #72

Merged
savanni merged 36 commits from file-service into main 2023-10-03 23:50:54 +00:00
Conversation 0 Commits 36 Files Changed 38 +5691 -223
savanni commented 2023-10-03 21:52:32 +00:00
Owner
Copy Link

This MR imports and old authentication library and an old file service application.

The authentication library is largely irrelevant, but is present mostly for historical, and refactoring, reasons.

The file service application originally was built with Iron. Before merging, I've updated it entirely to use Warp instead of Iron, and to have the HTML generated programmatically instead of via templates.

This resolves several issues and opens a variety more, mostly of the technical debt variety.

Resolves:

I've opened this MR under the belief that the application is now ready to be deployed to a server and won't be vulnerable to instant horrifying attack.

This MR imports and old authentication library and an old file service application. The authentication library is largely irrelevant, but is present mostly for historical, and refactoring, reasons. The file service application originally was built with Iron. Before merging, I've updated it entirely to use Warp instead of Iron, and to have the HTML generated programmatically instead of via templates. This resolves several issues and opens a variety more, mostly of the technical debt variety. Resolves: - https://www.pivotaltracker.com/story/show/186074563 - https://www.pivotaltracker.com/story/show/186074546 - https://www.pivotaltracker.com/story/show/186074535 - https://www.pivotaltracker.com/story/show/186174680 I've opened this MR under the belief that the application is now ready to be deployed to a server and won't be vulnerable to instant horrifying attack.
savanni added 33 commits 2023-10-03 21:52:33 +00:00
8c099d0586 Set up the delete route 
Sets up the delete route, including post-delete redirect back to the root.
Also adds logging.

Delete does not actually delete things yet.
d658747202 Start ripping out lots of infrastructure 
Much of the infrastructure is old and seems to be based on some assumptions about how Iron handled multipart posts. I don't understand how much of this works, so I'm slowly ripping parts out and rebuilding how the separation of concerns works.
90f9b80dd9 Add some tests to verify that a file can be added to the system 
Still gutting a lot of the old code, but this MR focuses more on ensuring that a file can be added and that the metadata gets saved.
09df915296 Validate the session token 
A previous commit added authentication token checks. Auth tokens are replaced with session tokens, which can (and should) expire. This commit validates sessions, which now allows access to gated operations.
f2bbb4e720 Validate the session token with file uploads 
File uploads now check the session token before continuing.

Resolves: https://www.pivotaltracker.com/story/show/186174680
savanni added 1 commit 2023-10-03 21:54:50 +00:00
savanni added 4 commits 2023-10-03 21:58:58 +00:00
savanni force-pushed file-service from 05c9e26c0f to 6fb872569d 2023-10-03 23:41:10 +00:00 Compare
savanni force-pushed file-service from 6fb872569d to 2f6be84a43 2023-10-03 23:50:17 +00:00 Compare
savanni merged commit 2f6be84a43 into main 2023-10-03 23:50:54 +00:00
savanni deleted branch file-service 2023-10-03 23:50:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
hex-grid

   
maintenance

   
music-player
No Label
hex-grid
maintenance
music-player
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: savanni/monorepo#72
No description provided.
Delete Branch "file-service"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?