savanni
/
monorepo
1
0
Fork 0
Code Issues 68 Pull Requests Projects 6 Releases Wiki Activity

Apply strict linting to release builds #75

Merged
savanni merged 21 commits from clippy-linting into main 2023-10-05 17:01:49 +00:00
Conversation 0 Commits 21 Files Changed 65 +407 -579
savanni commented 2023-10-05 16:49:48 +00:00
Owner
Copy Link

This is a big MR for setting up much stricter linting across all of my projects. There is now a lint command in build.sh. Lints and tests now run on release builds. I ran the linter on every project except for Orizentic. I resolved all warnings except for one warning in a macro that is both unclear how to resolve and unclear how to suppress.

Resolves:

This is a big MR for setting up much stricter linting across all of my projects. There is now a lint command in build.sh. Lints and tests now run on release builds. I ran the linter on every project except for Orizentic. I resolved all warnings except for one warning in a macro that is both unclear how to resolve and unclear how to suppress. Resolves: - https://www.pivotaltracker.com/story/show/186174693 - https://www.pivotaltracker.com/story/show/186174697
savanni added 21 commits 2023-10-05 16:49:48 +00:00
79219793cf Remove orizentic from the environment 
This needs a total overhaul and so isn't worth fixing right now.
d76a824987 Resolve tests which call the GameState constructor 
I changed the constructor from new() to default(), but didn't catch all of the tests.
cd8c411d09 Disable the komi test 
The SGF parser doesn't currently parse komi
savanni force-pushed clippy-linting from 728393972a to ef057eca66 2023-10-05 17:01:37 +00:00 Compare
savanni merged commit ef057eca66 into main 2023-10-05 17:01:49 +00:00
savanni deleted branch clippy-linting 2023-10-05 17:01:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
hex-grid

   
maintenance

   
music-player
No Label
hex-grid
maintenance
music-player
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: savanni/monorepo#75
No description provided.
Delete Branch "clippy-linting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?